Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35681 )
Change subject: cpu/x86/smm: Add support for long mode ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35681/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35681/6//COMMIT_MSG@10 PS6, Line 10: x86_32 isn't affected from this change. Test this with BUILD_TIMELESS=1?
https://review.coreboot.org/c/coreboot/+/35681/6/src/cpu/x86/smm/smmhandler.... File src/cpu/x86/smm/smmhandler.S:
https://review.coreboot.org/c/coreboot/+/35681/6/src/cpu/x86/smm/smmhandler.... PS6, Line 247: ia32efer_backup don't you want to place this in the .bss section?