Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi... PS5, Line 128: No GCM2 device and group2 is not visible to kernel
I will check the kernel driver.
Few things i observed. As suggested by Will i tried with adding GCM2 device in asl file and returning the GCM2 from the acpi path. Asl gets populated properly as expected but as kernel does not know about that device it simply does not do anything when the match is not found.I am adding some more logs in kernel to get the exact failure. But one thing : 1. If we do not have GCM2 then in pinctrl node in sysfs the devices are INT34C5:00, INT34C5:01, INT34C5:02, INT34C5:03 but if we have GCM2 then its INT34C5:00, INT34C5:01, INT34C5:03 INT34C5:04 even though the UID in asl file matches those in kernel driver. So seems like in order to have kernel list nodes properly we need to have dummy GCM2, GCM3 in coreboot. But i m not sure if we would have any problem without those. Even if kernel list those devices as 0,1,2,3 it would still work.