Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36774 )
Change subject: cpu/intel/slot_1: Move to C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36774/1/src/southbridge/intel/i8237...
File src/southbridge/intel/i82371eb/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36774/1/src/southbridge/intel/i8237...
PS1, Line 54: /* Enable access to the whole ROM, disable ROM write access. */
This probably limits bootblock size to 64 KiB.
With 256KiB flashes coreboot has trouble fitting if the bootblock is 64KiB, but I'll add a comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic751d42a1969fb79fb50366f766d8796846a0bc4
Gerrit-Change-Number: 36774
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Branden Waldner
scruffy99@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 12 Nov 2019 13:17:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment