Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30991 )
Change subject: intel/apollolake: Add fixed resources for VTd to system resources ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/30991/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30991/2//COMMIT_MSG@10 PS2, Line 10: this
these
Ack
https://review.coreboot.org/#/c/30991/2/src/soc/intel/apollolake/systemagent... File src/soc/intel/apollolake/systemagent.c:
https://review.coreboot.org/#/c/30991/2/src/soc/intel/apollolake/systemagent... PS2, Line 46: has been
were
Ack
https://review.coreboot.org/#/c/30991/2/src/soc/intel/apollolake/systemagent... PS2, Line 53: (MCHBAR32(GFXVTBAR) & VTBAR_MASK) / KiB
Did you mean to silently ignore the possible division remainder? (same for the other divisions here)
No, there is just this requirement of having this memory to be in KiB granularity. So there will be no rest.