Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35470 )
Change subject: mb/google/hatch: Add G2Touch Touchscreen support
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/dratini/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/...
PS1, Line 69: GTCH7503
That's right. It uses the i2c-hid driver based on this: https://review.coreboot.org/cgit/coreboot. […]
Ack
https://review.coreboot.org/c/coreboot/+/35470/1/src/mainboard/google/hatch/...
PS1, Line 73: ACPI_GPIO_OUTPUT_ACTIVE_LOW
I think it's the same. It passed through level reverse in octopus. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dbde7f8396da6335b22aeb4a9703336e2b862b8
Gerrit-Change-Number: 35470
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Sep 2019 20:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Chen Wisley
wisley.chen@quantatw.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment