Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49136 )
Change subject: soc/intel/alderlake: Refactor SoC code to maintain CPU and PCH PCIE RPs
......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49136/comment/a951de51_4fc8df5e
PS1, Line 72: register "PcieClkSrcUsage[0]" = "0x40"
you are right, this is all due to wrong naming in FSP, ideally this is CPU RP 1 getting PEG clk 0
Ack
https://review.coreboot.org/c/coreboot/+/49136/comment/a4b50201_0d9bf664
PS1, Line 75: register "PcieClkSrcUsage[3]" = "0x41"
Same here, as far as I understand it, this configures PCH CLKSRC 3 to be used for CPU PCIe RP 2.
Ack
https://review.coreboot.org/c/coreboot/+/49136/comment/06b46da8_ec9c2f74
PS1, Line 76: register "PcieClkSrcUsage[4]" = "0x42"
Same here, as far as I understand it, this configures PCH CLKSRC 4 to be used for CPU PCIe RP 3.
Ack
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49136/comment/75f1fb3f_2997f58a
PS2, Line 74: Enable CPU PCIE PEG Slot 1 and 2
Sure on it. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92123450bd7cfb2e70aae8de03053672a7772451
Gerrit-Change-Number: 49136
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Sat, 09 Jan 2021 11:12:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment