Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46930 )
Change subject: soc/mediatek/common: A common API for loading the blob file
......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46930/16/src/soc/mediatek/common/in...
File src/soc/mediatek/common/include/soc/mtlib_common.h:
https://review.coreboot.org/c/coreboot/+/46930/16/src/soc/mediatek/common/in...
PS16, Line 6: int load_blob_file(const char *name, unsigned long addr);
Please use this API for mt8183 sspm in this patch.
https://review.coreboot.org/c/coreboot/+/46930/1/src/soc/mediatek/common/inc...
File src/soc/mediatek/common/include/soc/mtlib_common.h:
PS1:
Then let's use this API for mt8183 sspm.
Left another comment in PS16.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie94001bbda25fe015f43172e92a1006e059de223
Gerrit-Change-Number: 46930
Gerrit-PatchSet: 16
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Dec 2020 08:22:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidi.lin@mediatek.com
Gerrit-MessageType: comment