Attention is currently required from: Cliff Huang, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55127 )
Change subject: soc/intel/common/acpi: add ACPI S0ix _DSM for Intel Power Engine Plug-in ......................................................................
Patch Set 4: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55127/comment/2667c8ff_5f17b7c5 PS4, Line 9: ( UUID: Please remove the space after (.
https://review.coreboot.org/c/coreboot/+/55127/comment/a72de2a0_10f24a06 PS4, Line 22: need to implemented needs to be implemented
File src/soc/intel/common/block/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/55127/comment/1e5699fb_7a0ef0f4 PS4, Line 34: s0ix S0ix
https://review.coreboot.org/c/coreboot/+/55127/comment/4e4b44b6_653195e0 PS4, Line 34: Generate s0ix entries for Intel power engine plug-in Maybe add:
Linux exposes this under `/sys/kernel/debug/pmc_core/substate_requirement_registers`.
File src/soc/intel/common/block/acpi/acpi/pep.asl:
https://review.coreboot.org/c/coreboot/+/55127/comment/92c99a78_58f69f11 PS4, Line 16: #define PEPD_PMC_PWRM_LPM_REQ_BITS_DATA_LEN 1536 I’d only use the first macro, and calculate the bit value from it.