Attention is currently required from: Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 2:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/1a0ce7a2_cf289cb4 PS2, Line 101: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/25050419_34a284e1 PS2, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/5576877d_a3fcf937 PS2, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/525fac2e_16ec0649 PS2, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/2d1369cd_e21836f9 PS2, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/82c8f040_37163c62 PS2, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/10c37931_187c877a PS2, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/ed301257_426ef738 PS2, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/ac3cbba2_c531d75f PS2, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/a8d8b79b_87c43829 PS2, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/0a039e7f_f0ca74a3 PS2, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/27f14125_9dca8d28 PS2, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/096b5b27_69315dd2 PS2, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/2642375b_ecb43de1 PS2, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970): https://review.coreboot.org/c/coreboot/+/52662/comment/e8d8c28e_5d0f6500 PS2, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('