2 Dec
2019
2 Dec
'19
2:39 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )
Change subject: binaryPI: implement C bootblock ......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/pi/nb_... File src/northbridge/amd/pi/nb_util.c:
https://review.coreboot.org/c/coreboot/+/36914/20/src/northbridge/amd/pi/nb_... PS20, Line 19: void *get_ap_entry_ptr(void)
Not needed anymore I guess
Right, put these in biosram.[ch]
--
To view, visit https://review.coreboot.org/c/coreboot/+/36914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29916a96f490ff717c69dc7cd565d74a83dbfb0d
Gerrit-Change-Number: 36914
Gerrit-PatchSet: 21
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Mike Banon mikebdp2@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Dec 2019 14:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-MessageType: comment