[coreboot-gerrit] Change in coreboot[master]: soc/intel/{cannonlake,icelake}: Do not define PCH_DEV_PMC in ramstage

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34120 )

Change subject: soc/intel/{cannonlake,icelake}: Do not define PCH_DEV_PMC in ramstage
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34120/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34120/2//COMMIT_MSG@10 
PS2, Line 10: This device gets hidden from PCI bus
            : in FSP-S
> I just thought it could have been added as a fixed domain resource, instead of faking the BAR on a d […]

That could be done as well, but one could also argue it's not really a part of the pci domain either. Either way would obviously work. Real question is what is the most appropriate. The presence of pci device is just a window into a more complex hierarchy of resources. That's why I was suggesting a platform device for fixed resources. Anyway, we domain device could be utilized as well, and if the system agent pci device became hidden we'd be in the same situation -- indicies need to be unique for resources and those need to be hung off of non-disabled devices because the resources are global.