Attention is currently required from: Felix Singer, Jason Glenesk, Nico Huber, Martin L Roth, Julius Werner, Arthur Heymans, Felix Held, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73095 )
Change subject: Documentation/releases: Add a number of "TODO" and "FIXME"
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73095/comment/2878ad9f_c4839544
PS5, Line 7: a number of
This means "more than two but fewer than many" and is a synonym for "several": https://www.merriam-webster.com/dictionary/a%20number%20of
Since you're not actually adding any TODOs or FIXMEs, how about:
Documentation/releases: List TODO and FIXME count
Or:
Documentation/releases: List how many TODOs and FIXMEs there are
File Documentation/releases/coreboot-4.20-relnotes.md:
https://review.coreboot.org/c/coreboot/+/73095/comment/dd60547b_8b00aa4b
PS3, Line 56: ```
in at least some cases the todo count is a misleading metric. […]
There's also the fact that there can be more TODOs and FIXMEs because new code got added without lowering the quality of existing code, e.g. new board ports, haswell NRI (which isn't complete yet)...
File Documentation/releases/coreboot-4.20-relnotes.md:
https://review.coreboot.org/c/coreboot/+/73095/comment/fb90f7b8_45bf0843
PS5, Line 40: Nbr.
nit: "Num." is the usual abbreviation for "number". Never seen "Nbr." before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d3989b2315c9c174cb6a484e96108460dac6e97
Gerrit-Change-Number: 73095
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 21 Feb 2023 16:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment