Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47151 )
Change subject: drivers/intel/gma: Add Kconfig option for vbt data size ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/Kconf... PS2, Line 102: config VBT_DATA_SIZE
Please move this somewhere above the `GFX_GMA_*` options.
Done
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/Kconf... PS2, Line 103: int
We usually use `hex` and absolute values for sizes, alternatively […]
Done
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/opreg... File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/47151/2/src/drivers/intel/gma/opreg... PS2, Line 22: 9
Please mention in the commit message that this was changed recently. […]
Done