Attention is currently required from: Dinesh Gehlot, Frank Chu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Martin L Roth, Matt DeVillier, Nick Vaccaro, Shawn Ku, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81136?usp=email
to look at the new patch set (#12).
Change subject: mb/google/nissa/var/glassway: Tune I2C timings for 400 kHz
......................................................................
mb/google/nissa/var/glassway: Tune I2C timings for 400 kHz
Update touchpad and touchscreen I2C timing.
- Data hold time: 300ns - 900ns
BUG=b:328724191
BRANCH=firmware-nissa-15217.B
TEST=Check wave form and met the spec.
I2C1 (touchscreen) Hold time from 83.58ns to 413.87ns
I2C5 (touchpad) Hold time from 95.93ns to 425.27ns
Change-Id: I65fb1298f9e96ab0b63aba436f6a319f21b38925
Signed-off-by: Frank Chu frank_chu@pegatron.corp-partner.google.com
---
M src/mainboard/google/brya/variants/glassway/overridetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/81136/12
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81136?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I65fb1298f9e96ab0b63aba436f6a319f21b38925
Gerrit-Change-Number: 81136
Gerrit-PatchSet: 12
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-MessageType: newpatchset