Attention is currently required from: Angel Pons, Arthur Heymans.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 )
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd() ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/asus/p8x7x-series/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61540/comment/ddd3959d_3f7701f6 PS2, Line 5:
nit: drop one space
Done
File src/mainboard/asus/p8x7x-series/variants/p8c_ws/early_init.c:
https://review.coreboot.org/c/coreboot/+/61540/comment/6253b71a_7737343b PS2, Line 5: #include <northbridge/intel/sandybridge/sandybridge.h>
I need it for the prototype of mainboard_should_reset_usb(), a MRC raminit hook that native raminit doesn't have. raminit_native.h includes this header, and I need nothing else from it.
Alright, but it's not required to factor out `mainboard_get_spd()`, right? If you want to change this, I'd suggest doing so in a separate commit.
I'll defer eliminating those includes in a separate "drop unneeded includes" patch.
Actually, looks like `mainboard_should_reset_usb()` could benefit from having a weak definition, as only one board has a different implementation.
I may want to just take that on.
Actually, except p8z77-m_pro and p8z77-m, all other boards in this group are all native and carry no MRC raminit hooks, meaning sandybridge.h isn't needed at all.
Should I eliminate MRC raminit support from these two boards as well? That is a new patch to be applied before this one. I'll adjust this patch accordingly.
No, do not eliminate MRC raminit support. The native codepath isn't complete. For example, PEG Gen3 support isn't implemented yet (only Gen2 speeds are supported).
ACK