Attention is currently required from: Bao Zheng, Raul Rangel, Rob Barnes, Karthik Ramasubramanian.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63722 )
Change subject: mb/google/nipperkin: Fix WLAN to GEN2 speed
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/63722/comment/82a47cd8_97d0f8b4
PS1, Line 12: sizeof(dxio_descriptors[WLAN].port_params));
Hi Rob,
so maybe we need to remove these since RP is config AC/DC to GEN2 in this patch? thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I988365e51aca0d6515c5605b3032521cf59d8d30
Gerrit-Change-Number: 63722
Gerrit-PatchSet: 1
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 20 Apr 2022 03:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment