Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41855 )
Change subject: soc/intel/tigerlake: add TCC activation functionality ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41855/3/src/soc/intel/tigerlake/cpu... File src/soc/intel/tigerlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/41855/3/src/soc/intel/tigerlake/cpu... PS3, Line 41: MSR_TEMPERATURE_TARGET Sumeet, this seems to be a common IA MSR. Would it make sense to move this functionality into soc/intel/common instead of tiger lake specific?