Attention is currently required from: Tim Wawrzynczak, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 )
Change subject: common: Begin Tiger Lake integration ......................................................................
Patch Set 8: Verified+1 Code-Review+1
(10 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/65087/comment/d513030a_c67f052b PS8, Line 10: . Nit, the period should be after the quotation.
Patchset:
PS8: Looks good overall and verification passes (with warnings because nothing is implemented of course). Will probably have to get back to this change once I've looked into everything.
File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/65087/comment/f9327735_21cef9c3 PS8, Line 38: => Please align up.
https://review.coreboot.org/c/libgfxinit/+/65087/comment/74579d39_bc1921cb PS8, Line 186: hswsklbool I supposse this and the next are `hswskltglbool` as well then.
https://review.coreboot.org/c/libgfxinit/+/65087/comment/c2dcbe5c_ab3c706b PS8, Line 327: tglhswvar I think this one should stay `hswvar`. Meaning, if the generation is Haswell, this can be variable at runtime. But for Tiger Lake it's always 6.
https://review.coreboot.org/c/libgfxinit/+/65087/comment/f028d648_722375ec PS8, Line 504: function Is_Tiger_Lake (Device_Id : Word16) return Boolean is : (Is_Tiger_Lake_U (Device_Id) or Is_Tiger_Lake_H (Device_Id)); Do we need this function?
https://review.coreboot.org/c/libgfxinit/+/65087/comment/3fb20b1d_c8b7c6cd PS8, Line 545: Is_Tiger_Lake_U (Device_Id))); No tabs, please.
File common/hw-gfx-gma-config_helpers.adb:
https://review.coreboot.org/c/libgfxinit/+/65087/comment/3084ddef_c504a7ba PS8, Line 53: ???? You couldn't test or you are unsure or...?
File common/hw-gfx-gma.adb:
https://review.coreboot.org/c/libgfxinit/+/65087/comment/b7e003d5_a85847ff PS8, Line 58: A little spurious indentation
https://review.coreboot.org/c/libgfxinit/+/65087/comment/d2a68324_470189e7 PS8, Line 59: => Please align up