Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45684 )
Change subject: console: Add config EARLY_OVERRIDE_LOGLEVEL for overriding early log level
......................................................................
Patch Set 1:
(1 comment)
This change isn't what I expected from CB:45134. I was expecting to remove the multiple checks for CONSOLE_LEVEL_CONST. This clean-up isn't needed for CB:45134, so it can be moved after it.
https://review.coreboot.org/c/coreboot/+/45684/1/src/console/init.c
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/45684/1/src/console/init.c@21
PS1, Line 21: EARLY_OVERRIDE_LOGLEVEL
This config isn't defined until CB:45134 and generally, I don't think the check is needed in this file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I532a88722c8e003b8e187a9714d26104c8ed8c6c
Gerrit-Change-Number: 45684
Gerrit-PatchSet: 1
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 17:12:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment