Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41992 )
Change subject: [WIP] sb/intel: Always raise SMI with APM_CNT_FINALIZE ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41992/2/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41992/2/src/southbridge/intel/bd82x... PS2, Line 214: return;
Ok.. Can we do something like this instead? […]
Should work. I also wonder if we shouldn't just drop INTEL_CHIPSET_LOCKDOWN (i.e. always lock). We (secunet) used it to defer flash lockdown into the payload. Which could also be handled more fine grained. But originally the finalize handler was called by depthcharge, I guess. Don't know what the requirements are there (or if anybody still cares).