Leo Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81832?usp=email )
Change subject: mb/google/nissa/variant/sundance: Modify i2c device for touch device ......................................................................
mb/google/nissa/variant/sundance: Modify i2c device for touch device
1. Modify i2c address 0x5d of Goodix touch IC for touch panel. 2. Add new i2c address 0x38 of Focal touch IC for touch pad
BUG=b:333804572 TEST=FW_NAME=sundance emerge-nissa coreboot chromeos-bootimage
Change-Id: I8e2c60820a07b99b69860fd4f6557b448aef2341 Signed-off-by: Leo Chou leo.chou@lcfc.corp-partner.google.com --- M src/mainboard/google/brya/variants/sundance/overridetree.cb 1 file changed, 12 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/81832/1
diff --git a/src/mainboard/google/brya/variants/sundance/overridetree.cb b/src/mainboard/google/brya/variants/sundance/overridetree.cb index 30c93e4..7517bfc 100644 --- a/src/mainboard/google/brya/variants/sundance/overridetree.cb +++ b/src/mainboard/google/brya/variants/sundance/overridetree.cb @@ -72,7 +72,7 @@ register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # WFC Camera register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for PCIe WLAN register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for CNVi WLAN - + register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3 port for WWAN
# Configure external V1P05/Vnn/VnnSx Rails for Sundance @@ -89,7 +89,7 @@ .v1p05_icc_max_ma = 500, .vnn_icc_max_ma = 500, }" - + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -144,53 +144,20 @@ device domain 0 on device ref i2c1 on chip drivers/i2c/hid - register "generic.hid" = ""ELAN901C"" - register "generic.desc" = ""ELAN Touchscreen"" + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" register "generic.detect" = "1" - register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "20" - register "generic.reset_off_delay_ms" = "2" - register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" - register "generic.stop_delay_ms" = "280" - register "generic.stop_off_delay_ms" = "2" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" - register "generic.enable_delay_ms" = "1" - register "generic.has_power_resource" = "1" - register "hid_desc_reg_offset" = "0x01" - device i2c 10 on end - end - chip drivers/i2c/hid - register "generic.hid" = ""PARA3406"" - register "generic.desc" = ""Parade Touchscreen"" - register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" - register "generic.detect" = "1" + register "generic.enable_delay_ms" = "20" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "20" - register "generic.reset_off_delay_ms" = "2" + register "generic.reset_delay_ms" = "180" + register "generic.reset_off_delay_ms" = "3" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" - register "generic.stop_delay_ms" = "280" - register "generic.stop_off_delay_ms" = "2" - register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" - register "generic.enable_delay_ms" = "1" + register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" - device i2c 24 on end - end - chip drivers/i2c/hid - register "generic.hid" = ""GTCH7503"" - register "generic.desc" = ""G2TOUCH Touchscreen"" - register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" - register "generic.detect" = "1" - register "generic.reset_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" - register "generic.reset_delay_ms" = "50" - register "generic.enable_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" - register "generic.enable_delay_ms" = "1" - register "generic.has_power_resource" = "1" - register "hid_desc_reg_offset" = "0x01" - device i2c 40 on end + device i2c 5d on end end end device ref i2c3 on @@ -222,14 +189,14 @@ device i2c 15 on end end chip drivers/i2c/hid - register "generic.hid" = ""SYNA0000"" + register "generic.hid" = ""FCAL0000"" register "generic.cid" = ""ACPI0C50"" - register "generic.desc" = ""Synaptics Touchpad"" + register "generic.desc" = ""Focal Touchpad"" register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F14_IRQ)" register "generic.wake" = "GPE0_DW2_14" register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" - device i2c 0x2c on end + device i2c 0x38 on end end end device ref pcie_rp4 on