Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31118 )
Change subject: google/kukui: Implement HW reset function
......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
I think we should split this into few CLs:
- Refactor wdt and move wdt_reset to reset.c (maybe add CONFIG_MISSING_BOARD_RESET to kukui so it won't build fail)
- Add board-specific implementation to kukui.
Or, we should consider doing weak link for board_reset...
Done. Thanks.
https://review.coreboot.org/#/c/31118/1/src/soc/mediatek/common/wdt_reset.c
File src/soc/mediatek/common/wdt_reset.c:
https://review.coreboot.org/#/c/31118/1/src/soc/mediatek/common/wdt_reset.c@...
PS1, Line 2: file
In other SOC, this is usually simply called reset.c. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9afad84af2031a766bc08fc76c8b5f55588c453a
Gerrit-Change-Number: 31118
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Jan 2019 08:40:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment