[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add measured boot mode

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29547 )

Change subject: security/vboot: Add measured boot mode
......................................................................

Patch Set 3:

(5 comments)

https://review.coreboot.org/#/c/29547/3/src/lib/prog_ops.c
File src/lib/prog_ops.c:

https://review.coreboot.org/#/c/29547/3/src/lib/prog_ops.c@40
PS3, Line 40: 	vboot_prog_run(prog);
if (IS_ENABLED(CONFIG_VBOOT_MEASURED_BOOT))
 ....

https://review.coreboot.org/#/c/29547/3/src/lib/prog_ops.c@50
PS3, Line 50: void __weak vboot_prog_run(struct prog *prog)
no need for weak

https://review.coreboot.org/#/c/29547/3/src/security/vboot/vboot_crtm.c
File src/security/vboot/vboot_crtm.c:

https://review.coreboot.org/#/c/29547/3/src/security/vboot/vboot_crtm.c@63
PS3, Line 63: 		    == 0) {
strange code formating

https://review.coreboot.org/#/c/29547/3/src/security/vboot/vboot_crtm.c@105
PS3, Line 105: void vboot_prog_run(struct prog *prog)
vboot_measure() ?

https://review.coreboot.org/#/c/29547/3/src/security/vboot/vboot_crtm.c@107
PS3, Line 107: 	switch (prog->type) {
map PROG_* to TPM_*_PCR instead, makes it more readable.