Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44947 )
Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................
util/mb/google: Update dalboz/trembyle template
- Fix relative path to spd folder. - Add spd folder with empty files.
BUG=None TEST=None
Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44947 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M util/mainboard/google/dalboz/template/Makefile.inc A util/mainboard/google/dalboz/template/spd/Makefile.inc A util/mainboard/google/dalboz/template/spd/dram_id.generated.txt A util/mainboard/google/dalboz/template/spd/mem_parts_used.txt M util/mainboard/google/trembyle/template/Makefile.inc A util/mainboard/google/trembyle/template/spd/Makefile.inc A util/mainboard/google/trembyle/template/spd/dram_id.generated.txt A util/mainboard/google/trembyle/template/spd/mem_parts_used.txt 8 files changed, 30 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/util/mainboard/google/dalboz/template/Makefile.inc b/util/mainboard/google/dalboz/template/Makefile.inc index 9dc5159..295acd2 100644 --- a/util/mainboard/google/dalboz/template/Makefile.inc +++ b/util/mainboard/google/dalboz/template/Makefile.inc @@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-or-later
-subdirs-y += ../baseboard/spd +subdirs-y += ./spd diff --git a/util/mainboard/google/dalboz/template/spd/Makefile.inc b/util/mainboard/google/dalboz/template/spd/Makefile.inc new file mode 100644 index 0000000..feabe7f --- /dev/null +++ b/util/mainboard/google/dalboz/template/spd/Makefile.inc @@ -0,0 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = diff --git a/util/mainboard/google/dalboz/template/spd/dram_id.generated.txt b/util/mainboard/google/dalboz/template/spd/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/dalboz/template/spd/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/dalboz/template/spd/mem_parts_used.txt b/util/mainboard/google/dalboz/template/spd/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/util/mainboard/google/dalboz/template/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional) diff --git a/util/mainboard/google/trembyle/template/Makefile.inc b/util/mainboard/google/trembyle/template/Makefile.inc index 9dc5159..295acd2 100644 --- a/util/mainboard/google/trembyle/template/Makefile.inc +++ b/util/mainboard/google/trembyle/template/Makefile.inc @@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-or-later
-subdirs-y += ../baseboard/spd +subdirs-y += ./spd diff --git a/util/mainboard/google/trembyle/template/spd/Makefile.inc b/util/mainboard/google/trembyle/template/spd/Makefile.inc new file mode 100644 index 0000000..feabe7f --- /dev/null +++ b/util/mainboard/google/trembyle/template/spd/Makefile.inc @@ -0,0 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = diff --git a/util/mainboard/google/trembyle/template/spd/dram_id.generated.txt b/util/mainboard/google/trembyle/template/spd/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/trembyle/template/spd/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/trembyle/template/spd/mem_parts_used.txt b/util/mainboard/google/trembyle/template/spd/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/util/mainboard/google/trembyle/template/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional)