Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39848 )
Change subject: mb/google/deltaur: Update onboard memory config ......................................................................
Patch Set 16:
(6 comments)
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 27: void variant_memory_init(FSP_M_CONFIG *mem_cfg);
weak this.
Done
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/deltan/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 16: verstage-y += gpio.c
same above.
Done
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 16: verstage-y += gpio.c
same above.
Done
https://review.coreboot.org/c/coreboot/+/39848/9/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/memory.c:
https://review.coreboot.org/c/coreboot/+/39848/9/src/mainboard/google/deltau... PS9, Line 56: .spd_smbus_address[1] = 0xa2},
I have updated the header to make this easier to use: https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/deltaur/memory.c:
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 49: int __weak variant_memory_sku(void)
not weak here.
Done
https://review.coreboot.org/c/coreboot/+/39848/14/src/mainboard/google/delta... PS14, Line 61: void __weak variant_memory_init(FSP_M_CONFIG *mem_cfg)
same above.
Done