Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37546 )
Change subject: New PCI ID for FCH SATA Controller (AHCI Mode) ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37546/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37546/1//COMMIT_MSG@9 PS1, Line 9: The 1022:7904 FCH SATA Controller is found in the AMD Bettong board.
Very strange, that there is another ID. […]
Paul, it's a different mode the existing controller may be set to.
If anything, I'm curious whether anything changed that caused the controller to be programmed this way by default. This is an uncommon configuration that should only be caused by setting HUDSON_SATA_MODE to 5. So the change is good for completeness.
See sb/amd/*/hudson/Kconfig -- actually, it looks like the Kconfig files didn't get updated for Carrizo and later. It's still using 7804 help text and IDs. I'd recommend updating those in this patch stack too, perhaps ahead of this one for clarity.
https://review.coreboot.org/c/coreboot/+/37546/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37546/1/src/include/device/pci_ids.... PS1, Line 451: #define PCI_DEVICE_ID_AMD_CZ_SATA_AHCI_AMD 0x7904
From https://pci-ids.ucw.cz/v2.2/pci.ids: […]
7900
https://review.coreboot.org/c/coreboot/+/37546/1/src/include/device/pci_ids.... PS1, Line 451: #define PCI_DEVICE_ID_AMD_CZ_SATA_AHCI_AMD 0x7904
Might replace_AMD with e.g. bettong to make difference between the two AHCI controllers.
I prefer not using the name Bettong. Bettong is the name of one particular board but this ID is used across multiple APUs, and even more boards. Also, in case it's not clear, it's the same controller which can be programmed to report one of several IDs.