Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44560 )
Change subject: mb/google/volteer: Add firmware configuration table for Halvor ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44560/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/fw_config.c:
https://review.coreboot.org/c/coreboot/+/44560/1/src/mainboard/google/voltee... PS1, Line 36: i2s_enable_pads i'd suggest renaming this to i2s_up3_enable_pads.
https://review.coreboot.org/c/coreboot/+/44560/1/src/mainboard/google/voltee... PS1, Line 49: I2S1_SCLK I2S2_SCLK
https://review.coreboot.org/c/coreboot/+/44560/1/src/mainboard/google/voltee... PS1, Line 55: GPP_R5 is this a NC on the schematics?
https://review.coreboot.org/c/coreboot/+/44560/1/src/mainboard/google/voltee... PS1, Line 56: PAD_CFG_NF(GPP_R6, NONE, DEEP, NF2), /* I2S1_TXD */ : PAD_CFG_NF(GPP_R7, NONE, DEEP, NF2), /* I2S1_SFRM */ i don't see these on the schematics.
https://review.coreboot.org/c/coreboot/+/44560/1/src/mainboard/google/voltee... PS1, Line 74: NONE a note about having CBI programmed before you need this. otherwise, you'll hit this case and and loose GPP_A23 HP_INT_L functionality.