Attention is currently required from: Tarun Tuli, Chen Wisley, Nick Vaccaro, Eric Lai.
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70171 )
Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/anahera/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/70171/comment/8481740c_be2baa47
PS3, Line 69: .speed_config[0] = {
I think you only need one of the parameter. try remove rise_time_ns and fall_time_ns.
Hi Eric,
It's urgent case. We already use the setting and build coreboot. Elan help to measure and confirm all timing meets their SPEC.
If we try to remove rise_time_ns/fall_time_ns, it could take time to measure again.
If it's not must modification, hope you can understand
Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70171
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404
Gerrit-Change-Number: 70171
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Chen Wisley
wisley.chen%quantatw.com@gtempaccount.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 01 Dec 2022 02:32:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment