Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35639 )
Change subject: coreboot_table: Use fmap_locate_area_as_rdev() for fmap_offset
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35639/3/src/lib/coreboot_table.c
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/35639/3/src/lib/coreboot_table.c@27...
PS3, Line 279: "FMAP",
Does anyone else find this sort of silly? Using fmap to find fmap. I think this is fine, but it certainly makes me chuckle.
Makes me wonder: what payload or application is using this parameter? It could be deprecated in the future, I suppose?
depthcharge on our end was using to obtain the FMAP offset instead of needing to maintain that static value in multiple places.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ff6e8199143d1a992a83d7de1e3b44813b733f4
Gerrit-Change-Number: 35639
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Sep 2019 16:06:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment