Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31367 )
Change subject: util/lint: Exclude util/inteltool from checkpatch
......................................................................
Patch Set 1:
Is it only about the line length? Could this warning be selectively
disabled?
It makes carefully hand-aligned tables a pain to review, e.g.
https://review.coreboot.org/#/c/coreboot/+/29897/4/util/inteltool/gpio_group...
I guess you could calm the line-length warning plus make the lines
longer so you can always use tabs, etc. But that might make the
table harder to review, too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae6cd4454c5ed84b5fe0ea5f8a244e2a2fa13407
Gerrit-Change-Number: 31367
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Feb 2019 12:44:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment