Wonkyu Kim has uploaded a new patch set (#8) to the change originally created by Rizwan Qureshi. ( https://review.coreboot.org/c/coreboot/+/39498 )
Change subject: src/soc/intel/tigerlake: Fix incorrect use of Field objects in ASL ......................................................................
src/soc/intel/tigerlake: Fix incorrect use of Field objects in ASL
Method RAOW is assuming that the first argument is a Field object and writing to it expecting the register to get updated. However, the callers are passing in the value of the Field object instead.
This eventually is resulting the IMGCLK not getting enable/disabled on the platform.
Fix this by sending the exact address of the register to be updated.
Also MCCT was setting the clock frequency in both case i.e, Clock Enable and Disable. Split the MCCT method in two, MCON and MCOF to fix the sequencing like below MCON: Set frequency Enable clock MCOF: Disable clock
Also, make use of MCON and MCOF methods for camera clock control in tglrvp. This is to avoid the buildbot marking the patch unstable.
BUG=None BRANCH=None TEST=Build and Boot waddledoo board and verified that IMGCLKOUT for world facing camera is enabled/disabled and able to capture images. Build and Boot Tiger Lake RVP board and verified that IMGCLKOUT for world facing camera is enabled/disabled and able to capture images.
Signed-off-by: Rizwan Qureshi rizwan.qureshi@intel.com Change-Id: I8b886255d5f38819502ae1f4af0851b5a0922b22 --- M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl M src/soc/intel/tigerlake/acpi/camera_clock_ctl.asl 2 files changed, 38 insertions(+), 97 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/39498/8