Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46853 )
Change subject: mb/google/volteer/variants: Describe USB ports in devicetree
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46853/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/voxel/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46853/1/src/mainboard/google/voltee...
PS1, Line 237: end
`end` not required here.
oops, will fix. need to run abuild against all variants not just volteer2,
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46853
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e5b71e7750a478ff79372c48616bbf5c21b79c
Gerrit-Change-Number: 46853
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 27 Oct 2020 21:38:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment