Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31375 )
Change subject: soc/intel/cannonlake: Configure serial debug uart
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31375/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31375/2//COMMIT_MSG@10
PS2, Line 10: SerialIoDebugUartNumber UPD use to select UART Number for Debug Purpose
Can you please add details indicating that this UPD defaults to 2 if not set and hence it needs to be initialized as per this config.
https://review.coreboot.org/#/c/31375/2/src/soc/intel/cannonlake/fsp_params....
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/31375/2/src/soc/intel/cannonlake/fsp_params....
PS2, Line 166: *
space after *
https://review.coreboot.org/#/c/31375/2/src/soc/intel/cannonlake/fsp_params....
PS2, Line 166: *
space before *
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91df4bb756e8ea86db112f1cc28687f48b2c0525
Gerrit-Change-Number: 31375
Gerrit-PatchSet: 2
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: RONAK KANABAR
ronak199323@gmail.com
Gerrit-Comment-Date: Tue, 12 Feb 2019 21:46:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment