10 May
2019
10 May
'19
4:03 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32727 )
Change subject: mb/lenovo/*: Add MAINBOARD_FAMILY ......................................................................
Patch Set 2:
Patch Set 1:
How about a single entry that defaults to MAINBOARD_PART_NUMBER? We could also get rid of the `#ifdef` in `smbios.c` this way.
Used a single Kconfig in src/mainboard/lenovo/Kconfig instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32727
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0033c42c5eac6b9d47d0acd16c67467b6d419534
Gerrit-Change-Number: 32727
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.com
Gerrit-Reviewer: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: James jye836@gmail.com
Gerrit-Reviewer: Marcello Sylvester Bauer sylvblck@sylv.io
Gerrit-Reviewer: Marian Tietz mtcoreboot@gmail.com
Gerrit-Reviewer: Nico Rikken nico@nicorikken.eu
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Sven Schnelle svens@stackframe.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Fri, 10 May 2019 14:03:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment