Attention is currently required from: Shuo Liu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80683?usp=email )
Change subject: soc/intel/xeon_sp: Refactor IOAT compiler optimization outs
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80683/comment/3f0b25b5_1b452cb1 :
PS3, Line 16: TEST=intel/archercity CRB
Is there a size and/or run-time difference? Please document that.
File src/soc/intel/xeon_sp/uncore_acpi.c:
https://review.coreboot.org/c/coreboot/+/80683/comment/b0504908_bd46208b :
PS3, Line 339: if (CONFIG(HAVE_IOAT_DOMAINS) && is_ioat_iio_stack_res(ri)) {
Is that pattern common in coreboot?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80683?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d16c6ff5320bc9195a1033b6d55e3d997b19b88
Gerrit-Change-Number: 80683
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Thu, 22 Feb 2024 19:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment