[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Remove I2C4

[Edward Hill (Code Review)]

Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43263 )

Change subject: soc/amd/picasso: Remove I2C4
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 1:
>
> Ah, the kernel is powering off the device since it doesn't think it has a purpose.
>
> Can you make this patch just the AOAC changes.

https://review.coreboot.org/c/coreboot/+/43263/2/src/soc/amd/picasso/aoac.c 
File src/soc/amd/picasso/aoac.c:

https://review.coreboot.org/c/coreboot/+/43263/2/src/soc/amd/picasso/aoac.c@... 
PS2, Line 28: FCH_AOAC_DEV_I2C4
> We still want to ensure it's powered don't we?

It seems to be powered up: the EC is able to talk to it.