Attention is currently required from: Nico Huber, Patrick Rudolph, Tim Wawrzynczak, Subrata Banik.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48658 )
Change subject: soc/intel/*: Add TPM decode range to soc_get_fixed_mmio_ranges()
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/xeon_sp/lpc.c:
https://review.coreboot.org/c/coreboot/+/48658/comment/33ee61b3_01afaf22
PS2, Line 13: { CONFIG_CRB_TPM_BASE_ADDRESS, 0x8000 },
: { CONFIG_TPM_TIS_BASE_ADDRESS, 0x8000 },
:
AFAIUI these Kconfigs are only there for overriding the fixed address in case the tpm doesn't comply with the TCG spec.
If a user/board overrides this value, we should not add that variable value to the lpc fixed ranges. Also, the Kconfig doesn't change the hardware (iow when the Kconfig changes, the soc will still decode 0xfed4000 and it should still be here).
IMO we should define the ranges/sizes per soc in include/soc/iomap.h and use these fixed ones here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f2257b55a712b936763cfd289c2c4b1633e8049
Gerrit-Change-Number: 48658
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Tue, 12 Jan 2021 19:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment