23 Jan
2020
23 Jan
'20
11:05 a.m.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38526 )
Change subject: ec/google/wilco: add ec command set cpu id ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38526/4/src/ec/google/wilco/command... File src/ec/google/wilco/commands.c:
https://review.coreboot.org/c/coreboot/+/38526/4/src/ec/google/wilco/command... PS4, Line 231: * MBOX[3] = CPUID_Low : * MBOX[4] = CPUID_Mid : * MBOX[5] = CPUID_High
This is EC spec, I don't know why. You can check in issue tracker.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/38526
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I135d2421d2106934be996a1780786f6bb0bf6b34
Gerrit-Change-Number: 38526
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: John Su john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jan 2020 18:05:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Mathew King mathewk@chromium.org
Gerrit-MessageType: comment