Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40612 )
Change subject: soc/intel/jasperlake: Enable end of post support in FSP
......................................................................
Patch Set 9: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/40612/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40612/9//COMMIT_MSG@10
PS9, Line 10: DXE modules are not part of FSP
nit: in API mode which coreboot currently uses.
https://review.coreboot.org/c/coreboot/+/40612/9/src/soc/intel/jasperlake/fs...
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40612/9/src/soc/intel/jasperlake/fs...
PS9, Line 20: )
nit: in API mode
https://review.coreboot.org/c/coreboot/+/40612/9/src/soc/intel/jasperlake/fs...
PS9, Line 21: )
nit: in API mode
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie21dcfc84d331f036090d01ea3e3925b81eea902
Gerrit-Change-Number: 40612
Gerrit-PatchSet: 9
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 May 2020 16:49:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment