Attention is currently required from: Rob Barnes. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63593 )
Change subject: mb/google/nipperkin: Disable PSPP for WLAN ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/63593/comment/9fff66ae_91ed8bc7 PS1, Line 17: memset(dxio_descriptors[WLAN].port_params, 0,
We do not fully understand the root cause of the failure, so I'm hesitant to apply the change to old […]
ok, if that problem wasn't there on older board revisions, let's not change those. aspm and pspp are different things which can both result in saving power, but both might not work with all devices. Did the older revisions use a different wifi card? since both loop and memset will basically do the same thing, let's keep using the memset here.