Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38381 )
Change subject: intel/i440bx: Use smbus_read_byte() for raminit debug
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG@9
PS1, Line 9: Build broke with CONFIG_DEBUG_RAM_SETUP
You might want to put a config file in /configs so that it gets build-tested.
+1 on adding a config file that exercises this option (can, and probably should be in a separate commit, but please do so before marking this comment "resolved")
https://review.coreboot.org/c/coreboot/+/38381/1//COMMIT_MSG@9
PS1, Line 9: Build broke with CONFIG_DEBUG_RAM_SETUP enabled after commit 3f882faf.
Please use […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib83885fc50c8fab61ced5ff18f22aa4655c5aaab
Gerrit-Change-Number: 38381
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 20 Jan 2020 10:54:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment