Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37020 )
Change subject: util/release: Don't try to remove a file named like a long string
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37020/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37020/1//COMMIT_MSG@7
PS1, Line 7: Don't try to rem
What does that mean?
$mainboard_list_{old,new} are strings of the form GOOGLE_VEYRON_MINNIE GETAC_P470 VIA_VT8454C ... I'm not sure what the original intent was here, but there's no file of that shape (and if there is, it's not ours to delete).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37020
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81fcb58720fb20ac4f57e31e9f991f5009aba568
Gerrit-Change-Number: 37020
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Nov 2019 21:49:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment