Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40243 )
Change subject: fmap: Avoid unaligned access
......................................................................
Patch Set 2:
Patch Set 2:
The general philosophy is that unaligned accesses need to be supported in common code.
I think that's a bad philosophy. IMHO, that's not even proper C.
There are many places we would have to fix (not just here but also in CBFS and elsewhere) if that wasn't the case.
Why not start here?
I can take a stab at fixing the fmap stuff if people would like. Let me know.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40243
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ac83766616cb2107b75eba6995cd09b4fc90968
Gerrit-Change-Number: 40243
Gerrit-PatchSet: 2
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Simon Glass
sjg@chromium.org
Gerrit-Comment-Date: Tue, 09 Jun 2020 23:01:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment