[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Move GPIO PM configuration to soc level

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )

Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................

Patch Set 13:
> Patch Set 13:
>
> @Subrata, I found the issue here. APL use the common platform.asl but not use the common globalnvs.asl that cause this issue. How can we fix this?

looks like its common vs specific SOC changes issue

now we have 2 option
1. Do you really need to save and restore GPIO PM setting in _PTS and _WAK, because _PTS/_WAK will only call for S5/S3 case where anyway your bootblock changes are in place to fix GPIO PM issue, isn't its duplicate ? i guess you have to only bother about MPTS/MWAK ?

2. Like SKL has its own platform.asl rather using common one. Its not feasible to make GPIO PM override feature flag for APL where this feature doesn't exist.