Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )
Change subject: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33738/10/src/soc/intel/icelake/Kcon... File src/soc/intel/icelake/Kconfig:
https://review.coreboot.org/c/coreboot/+/33738/10/src/soc/intel/icelake/Kcon... PS10, Line 24: select HAVE_FSP_GOP if !ENABLE_DISPLAY_OVER_EXT_PCIE_GFX
But, running graphics init on a different device than IGD doesn't make the GOP driver in FSP disap […]
That's unrelated to HAVE_FSP_GOP. Running a driver and having a driver are different aspects.
https://review.coreboot.org/c/coreboot/+/33738/10/src/soc/intel/icelake/Kcon... PS10, Line 211: select ALWAYS_LOAD_OPROM that conflicts with "Graphics initialization" menu, it only allows you to select VGA_ROM_RUN. If this is select by a mainboard, how can a user unselect it? For example if you have Linux as payload and you don't want graphics initialization in coreboot, what do you do?