Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38165 )
Change subject: soc/intel/tigerlake: Enable VT-d and generate DMAR ACPI table ......................................................................
Patch Set 9: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/38165/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38165/9//COMMIT_MSG@9 PS9, Line 9: Tigerlake Tiger Lake
https://review.coreboot.org/c/coreboot/+/38165/9/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/38165/9/src/soc/intel/tigerlake/acp... PS9, Line 259: sa_get_gsm_base(), sa_get_tolud_base() - 1); Does this fit into 96 characters?
https://review.coreboot.org/c/coreboot/+/38165/9/src/soc/intel/tigerlake/sys... File src/soc/intel/tigerlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/38165/9/src/soc/intel/tigerlake/sys... PS9, Line 66: ARRAY_SIZE(soc_vtd_resources)); Does this fit into 96 characters?