Dossym Nurmukhanov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41039 )
Change subject: libpayload/drivers/usb/xhci: Allow xHCI v1.2 in libpayload ......................................................................
Patch Set 3:
(3 comments)
Appreciate the comments.
https://review.coreboot.org/c/coreboot/+/41039/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41039/2//COMMIT_MSG@9 PS2, Line 9: Intel FSP requires xHCI v1.2 support in libpayload
So the issue is that FSP makes the chipset advertise 1. […]
Correct
https://review.coreboot.org/c/coreboot/+/41039/2//COMMIT_MSG@10 PS2, Line 10: This was sufficient for the : tests that I performed.
I think we now have three people who looked through Appendix I of the xhci 1. […]
Updated the comment. Would "Reviewed-by" in the CL be enough to identify the reviewers or you think I should explicit call them out in the description?
https://review.coreboot.org/c/coreboot/+/41039/2//COMMIT_MSG@15 PS2, Line 15: requires
advertises?
Done