Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35456 )
Change subject: [RFC] sconfig: Allow to give static device nodes a name
......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
So, this is my approach to get rid of the fragile
dev_find_slot_on_smbus() (see next commit for an
example).
I found out about the new expose_device_names() in
`sconfig/main.c` late during writing this, hence
some inconsistency (renaming objects vs. aliased
pointers). Just wanted to get some feedback early
if this is the right thing :)
https://review.coreboot.org/c/coreboot/+/35456/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35456/1//COMMIT_MSG@14
PS1, Line 14: as
Maybe learning Ada helps, but I feel like this keyword is a bit hard to understand.
Maybe "named" or something like that would help?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35456
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I058a319f9b968924fbef9485a96c9e3f900a3ee8
Gerrit-Change-Number: 35456
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 18 Sep 2019 15:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment