Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )
Change subject: payloads/tianocore: Enable UEFIPayload
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34459/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34459/7//COMMIT_MSG@14
PS7, Line 14: after PCIE_BASE set
any reason not to pass this in as a command line param since it's required for UefiPayloadPkg to boot?
https://review.coreboot.org/c/coreboot/+/34459/6/payloads/external/tianocore...
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/34459/6/payloads/external/tianocore...
PS6, Line 34: TIANOCORE_COREBOOTPAYLOAD
That's true, if people choose other than coreboot_fb branch (like origin/master), then build will br […]
for UefiPayloadPkg, offering the option to use a specific commit provides the user a workaround when upstream master inevitably breaks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7785fde9f4113b2cd91323ac0358b229c5a6e6
Gerrit-Change-Number: 34459
Gerrit-PatchSet: 7
Gerrit-Owner: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maurice Ma
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jul 2019 15:40:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Lance Zhao
lance.zhao@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment