Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36683 )
Change subject: region: add rdev_chain_full()
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36683/1/src/commonlib/include/commo...
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/c/coreboot/+/36683/1/src/commonlib/include/commo...
PS1, Line 80: return rdev_chain(child, parent, 0, region_device_sz(parent));
nit: could also just be memcpy()?
Not if parent is a root. We don't want non-root rdevs that have a lifetime that disappears.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie316790a8a5b16a7f7e22f86f58bd2e633c19450
Gerrit-Change-Number: 36683
Gerrit-PatchSet: 1
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 08 Nov 2019 21:38:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment